Closed jsitarek closed 3 years ago
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.37 β | 1.37 β | 0.00 |
Method Length | 63.71 π | 63.71 π | 0.00 |
Working memory | 11.62 π | 11.62 π | 0.00 |
Quality | 66.52% π | 66.52% π | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 537 | 537 | 0 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
agnpy/absorption/absorption.py | 66.52% π | 66.52% π | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
agnpy/absorption/absorption.py | Absorption.evaluate_tau_ss_disk | 0 β | 233 β | 18 β | 45.35% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/absorption/absorption.py | Absorption.evaluate_tau_blr | 0 β | 147 π | 15 π | 55.37% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/absorption/absorption.py | Absorption.evaluate_tau_dt_mu_s | 0 β | 140 π | 15 π | 56.14% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/absorption/absorption.py | Absorption.evaluate_tau_dt | 0 β | 131 π | 14 π | 58.43% π | Try splitting into smaller methods. Extract out complex expressions |
agnpy/absorption/absorption.py | Absorption.evaluate_tau_ps_behind_blob_mu_s | 0 β | 133 π | 11 π | 62.92% π | Try splitting into smaller methods. Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Let us know what you think of it by mentioning @sourcery-ai in a comment.
Merging #82 (91e5be0) into master (15d39d9) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 31 31
Lines 1896 1896
=======================================
Hits 1769 1769
Misses 127 127
Flag | Coverage Ξ | |
---|---|---|
unittests | 93.30% <100.00%> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Ξ | |
---|---|---|
agnpy/absorption/absorption.py | 94.70% <100.00%> (ΓΈ) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 15d39d9...91e5be0. Read the comment docs.
the value used was correct, but the explanation was wrong