cosimoNigro / agnpy

Modelling jetted Active Galactic Nuclei radiative processes with python
https://agnpy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 32 forks source link

fixed misleading comment #82

Closed jsitarek closed 3 years ago

jsitarek commented 3 years ago

the value used was correct, but the explanation was wrong

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.37 ⭐ 1.37 ⭐ 0.00
Method Length 63.71 πŸ™‚ 63.71 πŸ™‚ 0.00
Working memory 11.62 😞 11.62 😞 0.00
Quality 66.52% πŸ™‚ 66.52% πŸ™‚ 0.00%
Other metrics Before After Change
Lines 537 537 0
Changed files Quality Before Quality After Quality Change
agnpy/absorption/absorption.py 66.52% πŸ™‚ 66.52% πŸ™‚ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
agnpy/absorption/absorption.py Absorption.evaluate_tau_ss_disk 0 ⭐ 233 β›” 18 β›” 45.35% 😞 Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_blr 0 ⭐ 147 😞 15 😞 55.37% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_dt_mu_s 0 ⭐ 140 😞 15 😞 56.14% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_dt 0 ⭐ 131 😞 14 😞 58.43% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions
agnpy/absorption/absorption.py Absorption.evaluate_tau_ps_behind_blob_mu_s 0 ⭐ 133 😞 11 😞 62.92% πŸ™‚ Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

codecov[bot] commented 3 years ago

Codecov Report

Merging #82 (91e5be0) into master (15d39d9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          31       31           
  Lines        1896     1896           
=======================================
  Hits         1769     1769           
  Misses        127      127           
Flag Coverage Ξ”
unittests 93.30% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
agnpy/absorption/absorption.py 94.70% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 15d39d9...91e5be0. Read the comment docs.