search

cosimoNigro / agnpy

Modelling jetted Active Galactic Nuclei radiative processes with python
https://agnpy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 33 forks source link

Fix the black body SEDs of the Disk and the Dust Torus (Sourcery refactored) #95

Closed sourcery-ai[bot] closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Pull Request #92 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the fix_disk_and_dt_bb branch, then run:

git fetch origin sourcery/fix_disk_and_dt_bb
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.96 ⭐ 1.96 ⭐ 0.00
Method Length 66.03 🙂 65.68 🙂 -0.35 👍
Working memory 10.42 😞 10.42 😞 0.00
Quality 68.94% 🙂 68.94% 🙂 0.00%
Other metrics Before After Change
Lines 485 488 3
Changed files Quality Before Quality After Quality Change
agnpy/targets/targets.py 68.94% 🙂 68.94% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
agnpy/targets/targets.py SSDisk.__init__ 9 🙂 208 ⛔ 13 😞 43.83% 😞 Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py SSDisk.u 1 ⭐ 148 😞 16 ⛔ 53.14% 🙂 Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py RingDustTorus.__init__ 2 ⭐ 92 🙂 16 ⛔ 59.12% 🙂 Extract out complex expressions
agnpy/targets/targets.py SphericalShellBLR.u 1 ⭐ 136 😞 10 😞 63.47% 🙂 Try splitting into smaller methods. Extract out complex expressions
agnpy/targets/targets.py SSDisk.__str__ 0 ⭐ 65 🙂 16 ⛔ 65.13% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!