search

cosimoNigro / agnpy_paper

Repository containing scripts to produce the plots in the agnpy paper.
4 stars 2 forks source link

EC comparisons with JetSet: Disk #6

Open cosimoNigro opened 3 years ago

cosimoNigro commented 3 years ago

Hello,

let us discuss in this thread the comparisons for EC with jetset that were suggested by Justin. I started to work on them in the jetset_ec_test branch. Here let us comment on the disk.
Here the link to the jetset documentation on External Compton. I think there is a 1:1 correspondence with the parameters we use, see the test_jetset_ec_disk.py script in the branch.

I used the same distances of the crosscheck:

Let me know what do you think.

jsitarek commented 3 years ago

after the emails of Andrea, I think the disk IC is the one that is still the one giving most of the problems. I'm not sure if the plots above are compute in "disk" frame or "blob" frame (from the email discussion it seems that the former should not be used), but even in the case of blob frame there are some discrepancies. @cosimoNigro were you able to figure out with Andrea if the assumptions are the same for the disk IC? Either way, I think such comparison we probably do not need in the paper.

cosimoNigro commented 2 years ago

After some work by @andreatramacere in jetset the comparison improved a lot:

figure_8

@jsitarek commented in the PR adding this comparison to the main code of the repository that

it would be good that all the curves have the same range, in some of the plots jetset seem to cut off at the lowest energies.

@andreatramacere, can we change this lower frequency where the spectrum is dropping to 0?

andreatramacere commented 2 years ago

@cosimoNigro this change requires a change in the C code. If I do that, I need to make a new release with all the tests. It might take some time, but I can do it.

jsitarek commented 2 years ago

Hi @andreatramacere @cosimoNigro Since the difference is understood, I think it will be simpler to just cut the agnpy one to start an order of magnitude higher in energy. The extension below it is just the simple self-absorbed case, that we already have covered over a few orders of magnitude

andreatramacere commented 2 years ago

@jsitarek, yes this is the easiest solution.

cosimoNigro commented 2 years ago

Ok, done

figure_8