cosimoNigro / agnpy_paper

Repository containing scripts to produce the plots in the agnpy paper.
4 stars 2 forks source link

EC comparisons with JetSet: BLR #7

Open cosimoNigro opened 2 years ago

cosimoNigro commented 2 years ago

Hello,

let us discuss in this thread the comparisons for EC with jetset that were suggested by Justin. I started to work on them in the jetset_ec_test branch. Here let us comment on the BLR.
Here the link to the jetset documentation on External Compton. I think there is a 1:1 correspondence with the parameters we use, see the test_jetset_ec_blr.py script in the branch. The shell cannot be made infinitesimally thin, so I set the outer radius to be 1.01 times the inner one.

I used the same distances of the crosscheck:

Let me know what do you think.

cosimoNigro commented 2 years ago

I made the BLR slightly narrower and used this feature that allows to transform the electron distribution in the disk frame (the docs say it should be used for distances smaller than the BLR radius).

The jetset SEDs is very near to a factor 2 that produced by agnpy jetset_ec_blr_comparison_r_1 10e+16_cm :man_shrugging:

jsitarek commented 2 years ago

Hi @cosimoNigro,

did you check how jetset is treating the angles? If you are within the BLR radiation field the angular distribution of the radiation does not matter much, but if you are far from it, it make a lot of difference if the photons are considered to be moving on axis, or at an angle to it.

cosimoNigro commented 2 years ago

Performing some of the tests @jsitarek requested in another thread:

before giving up with jetset, could you make two simple test:

  1. compare the two with the case of non-relativistic blob (e.g. Gamma = 1.001)

Here goes the non-relativistic case:

  1. compare the two forcing the observation angle to be on axis (theta << 1/ Gamma).

Here goes the on-axis case:

Will add the same tests for EC on DT tomorrow.

Scripts to perform these tests with jetset are now available in the master, see the jetset_tests repository.

jsitarek commented 2 years ago

Hi @cosimoNigro one more thing came to my mind. In the "far" case the distance is about 3 orders of magnitude larger than the size of the sphere. This is very tricky to compute (and also pretty unrealistic scenario), and the angles there could make a huge difference (there will be a difference between 0 deg (on axis) and 0.05 deg. Depending how the integrals are being done this can also end up with large uncertainties(if the integration is over the sphere of BLR this is more or less fine, but if the integration is done over the angles w.r.t. observation direction this can have problems here). Have you checked also the case of moderately distant source (d = a few - 10 * R_BLR)?

jsitarek commented 2 years ago

follow up from the e-mail discussion: after fixing the transformation issue in the jetset the BLR comparison looks quite fine (some differences at very large distances can be related to the accuracy of integrals). Such a comparison might actually be added to the paper. What do you think @cosimoNigro ?

cosimoNigro commented 2 years ago

After some work by @andreatramacere in jetset the comparison improved a lot:

figure_9

And @jsitarek commented in the PR adding this comparison to the main code of the repository that:

the difference are way too large for confort, reaching a factor 2, it would be good to understand if they come from different assumptions. Otherwise, a possibility is that they are affected by the numerical integration uncertainties, do you have a possibility in jetset to apply a finer integration to see if the results do not change considerably? In particular the EC on BLR for r >> Rline difference might be related to the accuracy of integration over angles, those are really tricky cases

I think it definitely comes from different assumptions. Rather than a monochromatic line, the BLR in jetset is reflecting the entire disk emission, so I think is producing another black body, correct @andreatramacere? Can you point us to the reference you are using, if there is one, to model the BLR?

I don't think it's an accuracy problem since in the last PR we have increased the Lorentz factor and solid angle integration grids.

andreatramacere commented 2 years ago

@cosimoNigro, these are the references:

Regarding the differences, it is a bit complicated because here we mix different implementation of the geometry, plus a different radiation field. In this plot, jetset is using a single temperature BB. We might optimize the temperature to have the best agreement w.r.t. the monochromatic line in agnpy. Or, I could implement the line in jetstet

jsitarek commented 2 years ago

would be interesting to really test it, but indeed it is likely that line vs full BB shape is the reason for discrepancy (in particular shift of peaks and smoothening up the sharp features in agnpy). This needs to be clearly explained in the text that the underlaying assumptions are different