cositools / cosipy

The COSI high-level data analysis tools
Apache License 2.0
4 stars 18 forks source link

Simplify get_point_source_response. Compute dwell_time_map from scatt_map + coordinate #107

Open israelmcmc opened 10 months ago

israelmcmc commented 10 months ago

Around here: https://github.com/cositools/cosipy/blob/a14d9667ead0206e0dbad0acf27a2ccd1cb2e14d/cosipy/response/FullDetectorResponse.py#L838

For historial reasons, get_point_source_response now takes either a dwell_time_map (called "exposure map") in the code, or the combination of a scatt_map and a coordinate. In reality, the exposure_map can be computed from the second option. We should deprecate the exposure map and compute it on the fly if needed. It should also be faster for multiple coordinate, since once you have the scatt_map then you don't need to loop through the orientation file again.