how to deal with gaussian normalisation

cositools / cosipy

The COSI high-level data analysis tools

Apache License 2.0

3 stars 16 forks source link

how to deal with gaussian normalisation #128

Open GallegoSav opened 5 months ago

GallegoSav commented 5 months ago

minor changes :

now we can read response file with gaussian spectrum
if there is only one bin the normalization is treat as same as the Mono one
Check if there is one bin and if the gaussian spectrum is fully contained in that bin
Raise a NotImplementedError if there are more than one bin with gaussian spectrum

israelmcmc commented 5 months ago

Thanks, @GallegoSav . I haven't had time to run it yet, but I checked the code and the logic looks good to me.

israelmcmc commented 3 months ago

@GallegoSav sorry I kept forgetting to check this! Do you think we need to merge this before DC2? I don't think so, and I'd rather merge as little code as possible right before the release, but please let me know if you think we do need it. Otherwise, I'll come back to this after the release.

israelmcmc commented 3 months ago

I changed the target branch to "develop". I want to avoid adding new features to the version we're releasing today. I'll explain this further tomorrow during the cosipy meeting.

GallegoSav commented 3 months ago

I changed the target branch to "develop". I want to avoid adding new features to the version we're releasing today. I'll explain this further tomorrow during the cosipy meeting.

Yeah no problem, indeed I don't think it is necessary for DC2 as there is no source with gaussian spectrum so far I suppose