cositools / cosipy

The COSI high-level data analysis tools
Apache License 2.0
3 stars 16 forks source link

COSIpy Installation - missing files (in setuptools include_package_data) #134

Closed avalluvan closed 3 months ago

avalluvan commented 4 months ago

Hi team, I have installed COSIpy within a virtual python environment (v3.10) over WSL (Ubuntu 22.04). When I tried to run the Data I/O notebook out-of-the-box, the following input "housekeeping" files were missing: Screenshot 2024-02-13 215645 Screenshot 2024-02-13 215745 Screenshot 2024-02-13 215813

Performing a simple wget from the source fixed the issue.

ckarwin commented 4 months ago

Thanks for catching this, @avalluvan. The missing housekeeping files are actually not currently needed, and so I've removed this from the code. I just submitted a PR to resolve this issue.

israelmcmc commented 4 months ago

Thanks for reporting this, @avalluvan. Indeed @ckarwin's fix will work for now, but the underlying issue is that I forgot that setuptools does not include all the data by default, only the code source files. I need to use include_package_data. I'll merge @ckarwin's PR, but I'll keep this issue open to remind me to fix this for the public release.

StevenBoggs commented 4 months ago

I am having the same issue in MacOS, M1 Max. How exactly do we implement @ckarwin 's fix to get past this error in the testing? (Or do we wait for the public release?)

StevenBoggs commented 4 months ago

I think I figured it out, I made @ckarwin 's modifications in my local DataIO.py file. :-)

ckarwin commented 4 months ago

Yes, thanks @StevenBoggs. That's the fix for now until we make an updated release.

israelmcmc commented 4 months ago

@ckarwin I made a new alpha release (v0.0.2a3) to include your changes and fix this particular problem with the DataIO.

I still need to see which other files to list in include_package_data, but this should work for now.

ckarwin commented 4 months ago

Great, thank you. Are you going to keep this issue open for now?

israelmcmc commented 4 months ago

Yeah, I want to make a list of all the files that are really needed so I can include them in the release. Maybe we can discuss this next week.

ckarwin commented 4 months ago

Yes, sounds good.

israelmcmc commented 3 months ago

I'm closing this because we are now not using the test_data for the examples at all, only data from wasabi.