search

cositools / cosipy

The COSI high-level data analysis tools
Apache License 2.0
3 stars 16 forks source link

GRB localization - unable to open file #136

Closed StevenBoggs closed 3 months ago

StevenBoggs commented 4 months ago

I'm trying out the GRB localization notebook. (Beautifully done notebook BTW!) Commands [1]-[6] seemed to work OK -- there was no indication of successful execution, just no errors. On command [7] I get this missing file error, it looks like it is looking for the developer's directory?

Screenshot 2024-02-15 at 1 37 09 PM

Yong2Sheng commented 4 months ago

Hi Steven,

Thank you for trying it out! Could you please try to replace the response path to see if it can solve the issue? It's the 5th cell of the notebook:

image

Thanks!

StevenBoggs commented 4 months ago

Hahaha, thanks @Yong2Sheng , amateur error on my part. Still having some troubles on this workbook but I will document them and submit.

israelmcmc commented 4 months ago

Thanks, @StevenBoggs and @Yong2Sheng . @Yong2Sheng: can you please move all the paths the user needs to replace to variables in a single cell near the top? I think that would make it less error prone.

ckarwin commented 4 months ago

I copy below a comment from @StevenBoggs. In general, this will be a good format to follow for all the notebooks:

Two minor comments on that. First, I really like how the spectral notebook has each of the file downloads in a separate cell so they can be run individually as needed. Second, it would be a nice touch to add the file size next to each listed file to download just to give some idea how large these will be while we are waiting for each to download.

israelmcmc commented 3 months ago

150 closes this issue.