Spacecraft file tutorial

israelmcmc commented 4 months ago

Closed #147

I'll track my changes here to coordinate with @Yong2Sheng

Changed the name of the nb
Removed mention of deprecated formats. We only use the .ori files right now.
I merged all of @Yong2Sheng commits from #150
@Yong2Sheng : good ideas to get the unique pixels during the dwell time map calculation! That inspired me to update a few lines to make it even faster!
dts in SpacecraftFile is time a TimeDelta object, not Time (as it should).
I did a general overhaul of the SpacecraftFile and DetectorResponse tutorials. I added information, better plots, reorganized the text, etc.

israelmcmc commented 3 months ago

@Yong2Sheng Can you please check and merge this PR? In particular, that both tutorials work, that I didn't remove any information you wanted, and that SpacecraftFile.py still works well.

Yong2Sheng commented 3 months ago

Hi @israelmcmc,

I reviewed the PR, it looks great! I really like your algorithm to get the summed pixel durations.

I tested DetectorResponse.ipynb and SpacecraftFile.ipynb. They both ran very well.

I only have one minor comment on one line I posted above.

Thank you very much!

israelmcmc commented 3 months ago

Note: all commits from PR #150 were merged here.

israelmcmc commented 3 months ago

Thanks @Yong2Sheng, I'll merge it

cositools / cosipy

Spacecraft file tutorial #149