I'm collecting ideas for the SC file API as I see them. No need to implement them right now, but when we start working on making the code style and API uniform across all modules.
Init function takes a scoord Attitude object.
Internally, store this information as opposed to the individual directions, and keep converting them
Add property "timestamps" and remove get_times. Same for time_delta
Add property "attitude".
interpolate() returns a SpacecraftFile with points interpolated at the input times.
Make interpolatedirection an internal function (start with )
Make get_attitude an internal function
Create a dwell time map class. Also, dwell_time shouldn't be a property stored in SpacecraftFile
src_path (src_path_skycoord) shouldn't become a property of SpacecraftFile. It should always be an input, less error prone.
All internal properties should be listed in init. Proper internal variables start with an underscore. All other attributes need a function, which can have the property decorator.
In general, avoid caching results inside the class. Let this be for the user to decide.
Use object instead of str for the inputs of functions. For example, the response path and the dwell time map path. This prevents having to re-load from disc if the user has already done it.
More get_arf(), get_rmf() and get_pha() to the DetectorResponse class.
dt and dt_format are not needed in get_dwell_map since the class object knows the timestamps.
israelmcmc
commented
1 month ago
I'm collecting ideas for the SC file API as I see them. No need to implement them right now, but when we start working on making the code style and API uniform across all modules.
get_arf(),get_rmf()andget_pha()to the DetectorResponse class.