cositools / cosipy

The COSI high-level data analysis tools
Apache License 2.0
3 stars 16 forks source link

Parallel Richardson-Lucy Algorithm Implementation #189

Open avalluvan opened 2 weeks ago

avalluvan commented 2 weeks ago

This pull request contains a parallel implementation of the Richardson-Lucy algorithm. Although the scripts can be run out-of-the-box with the instructions given in the README file, it is not adapted to the COSIpy framework yet nor is it written to be imported with python notebooks. It is intended to run the script with appropriate changes to its dependent configuration file. I am initiating this pull request to invite code reviews and start a discussion on what is necessary to port this to COSIpy.

Link to the original file: https://github.com/avalluvan/Richardson-Lucy/

ckarwin commented 2 weeks ago

Thanks for making a PR, @avalluvan! For now, can you please change the PR to a draft, since it's not ready to be reviewed for merging yet? It sounds like @hirokiyoneda would be the best person to look over this.

hiyoneda commented 2 weeks ago

Thanks @avalluvan. I am checking the codes now and agree to make this PR a draft. Then, members can test and check how to use the parallel calculation. @avalluvan, if you can, please consider the following things:

The parallel calculation parts are R M and R^{T} (D/E), which are related to how to handle the image response matrix rather than the RL algorithm itself. So, I want to reflect Anaya’s code on the response class (and other classes can also use it), though currently, we don't have the image response class.