search

cositools / cosipy

The COSI high-level data analysis tools
Apache License 2.0
3 stars 16 forks source link

conflict with scoords and coordinates #83

Closed ckarwin closed 7 months ago

ckarwin commented 9 months ago

I believe there is a conflict between Attitude in the scoords class and attitude in the coordinates class. This causes an error in the dataIO class. As mentioned in another issue, the coordinates class has not been initialized properly, i.e. by specifying it in init.py. I fixed this in my branch, but then when I ran read_tra in the DataIO class I got an error: Attitude is not an instance of Attitude. This came after defining a SkyCoord Object with the spacecraft frame, and trying to rotate it (see lines 231 and 232 in UnBinnedData.py).

I was able to fix this error by not initializing the coordinate class in init.py.

ckarwin commented 7 months ago

I think this has been resolved now in all the latest PRs. I'll close this issue, and reopen if needed.