lock on language selection and acceptance of terms

coskundeniz / ad_clicker

Google Ads clicker

https://coskundeniz.github.io/ad_clicker/

GNU General Public License v3.0

161 stars 62 forks source link

lock on language selection and acceptance of terms #17

Closed javivaz closed 1 year ago

javivaz commented 1 year ago

The first time the browser window is opened, the language selector appears and stays there without completing any other action. Below the language selector, the acceptance of the default browser terms appears in any incognito window. After a few seconds without action, it closes and returns a message that no results were found.

coskundeniz commented 1 year ago

@javivaz I couldn't reproduce it on my local. Can you give more details and maybe also a recording? Please send the adclicker.log file too. Thank you.

ebulku commented 1 year ago

Yes this is happening sometimes, based also on the size of the window, and not recognizing the buttons at the end of the modal. We have to add another scroll at the bottom of the modal I think.

javivaz commented 1 year ago

Sorry, I didn't see your message. Indeed, it seems that something has changed. It is not frequent but it does happen sometimes. Thank you for your attention

furkankadioglu commented 1 year ago

Hey @coskundeniz Here is my adclicker.log, I have same issue.

I28-04-2023 02:19:53 [DEBUG] utils.py:166: Installed Chrome version: 112
28-04-2023 02:19:58 [ INFO] search_controller.py: 68: Starting search for 'wireless keyboard'
28-04-2023 02:20:10 [ERROR] search_controller.py: 94: Timed out waiting for results!
28-04-2023 02:20:10 [ INFO] ad_clicker.py: 88: No ads in the search results!

coskundeniz commented 1 year ago

Yes this is happening sometimes, based also on the size of the window, and not recognizing the buttons at the end of the modal. We have to add another scroll at the bottom of the modal I think.

I also tried by decreasing the browser window size but still cannot reproduce. I will take a look if I see it during my runs.

furkankadioglu commented 1 year ago

It might be related with OS Language / Geolocation. I using English language with Turkish Keyboard and my location is Portugal. Not sure but looks like related. @coskundeniz

furkankadioglu commented 1 year ago

@coskundeniz

Well, after few tests with VPN now I pretty sure. When I enable my Turkish VPN this modal disappearing. So you should try to reproduce with another language or with a VPN.

And one more thing, there is another issue. When I run it after first ad visit browser is crashing. Screen Shot 2023-04-29 at 03 29 36

Thanks for this perfect project mate.

coskundeniz commented 1 year ago

Should be fixed with the latest version.

coskundeniz commented 1 year ago

@coskundeniz

Well, after few tests with VPN now I pretty sure. When I enable my Turkish VPN this modal disappearing. So you should try to reproduce with another language or with a VPN.

And one more thing, there is another issue. When I run it after first ad visit browser is crashing.

Thanks for this perfect project mate.

Thank you for the advise. I was able to reproduce by using a proxy from Switzerland. If crash issue is reproducible, you can create a separate issue for it.