coslyk / moonplayer

Video player that can play online videos from youtube, bilibili etc.
https://coslyk.github.io/moonplayer.html
GNU General Public License v3.0
631 stars 93 forks source link

[BUG] Segmentation fault with youtube stream #106

Closed Flashwalker closed 3 years ago

Flashwalker commented 3 years ago

Describe the bug

Segfault during the attempt to play youtube video format 22

Error output

qrc:/qml/main.qml:237:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/OpenUrlDialog.qml:37:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/TextInputDialog.qml:34:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/main.qml:97:9: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/MessageDialog.qml:36:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
qrc:/qml/ConsoleDialog.qml:66:5: QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }

To Reproduce Steps to reproduce the behavior:

  1. Open moonplayer in terminal
  2. Go to 'Playlist'
  3. Click on ' ADD > Url...'
  4. Enter youtube URL to parse
  5. Click on 'OK', wait for parsing
  6. Scroll down to '22 - 1280x720 (720) (mp4 )' stream, or other than the first two
  7. Select stream '22 - 1280x720 (720) (mp4 )', or other than the first two
  8. Click on 'OK'
  9. See segfault error in terminal

Screenshots


System information (please complete the following information):

Additional context

Appimage

coslyk commented 3 years ago

Can't reproduce. Can you provide the URL that you test with?

Flashwalker commented 3 years ago

URL: https://youtu.be/rmnruY4xmGY

coslyk commented 3 years ago

Thanks for your report. It's now fixed in the latest commit.