search

cosme12 / SimpleCoin

Just a really simple, insecure and incomplete implementation of a blockchain for a cryptocurrency made in Python as educational material. In other words, a simple Bitcoin clone.
http://copitosystem.com
MIT License
1.78k stars 397 forks source link

Added improvements at creating a new address and prove of work #20

Closed adanielpincab closed 6 years ago

cosme12 commented 6 years ago

@Pineapple6 now it has conflict. You will have to save your changes. Pull the branch again and apply the changes manually. Sorry for being annoying 😬

adanielpincab commented 6 years ago

I'm trying to solve the conflict, sorry for all the reopen and close 😅

adanielpincab commented 6 years ago

Ok, It's ready.

cosme12 commented 6 years ago

Cool. Lets discuss the changes. I really like the part of saving the keys to a text file. Copying from command line is pretty annoying. especially in old windows versions. Now, the proof of work change. Should we really change it? I see it adds a lot of complexity to the code, destroying its main purpose of being super simple. What do you think?

adanielpincab commented 6 years ago

I don't exactly know. Obviously, if the proof of work is more complex it's code will be also more complex. If you want it, I can send a pull request only with the adding an address changes and try to optimize the code in the proof of work.

cosme12 commented 6 years ago

if it's not much hassle, send the "new address to text file" commits in pull request, so we can accept that. And then we keep thinking what to do with the proof of work.

adanielpincab commented 6 years ago

Ok. I can't do it right now, but tomorrow I'll do what you say :+1: