Improvements to wallet.py

cosme12 / SimpleCoin

Just a really simple, insecure and incomplete implementation of a blockchain for a cryptocurrency made in Python as educational material. In other words, a simple Bitcoin clone.

http://copitosystem.com

MIT License

1.78k stars 397 forks source link

Improvements to wallet.py #28

Closed Aareon closed 6 years ago

Aareon commented 6 years ago

Supersedes https://github.com/cosme12/SimpleCoin/pull/25

Removed f-string to retain comptability with Python versions < 3.6.
Added use of context manager when opening, writing, and closing the file.
Removed the welcome_msg function and moved it’s content into the main conditional.
Replaced if response in int: conditions with if response == int:

Aareon commented 6 years ago

I’ll officially test these changes today. For the time being, do not merge.

cosme12 commented 6 years ago

Hey, I tested it and there are some little bugs, but overall seems to be a good idea. I'm going to add your pull request and then fix the little problems. Thanks for the help!

Aareon commented 6 years ago

What issues have you had, btw?

cosme12 commented 6 years ago

There were a few missing ) and a syntax error. But nothing big.

Aareon commented 6 years ago

Awesome. Good to hear. I believe with this PR, #25 can be closed