search

cosmic-pi-deprecated / cosmicpi-daq

Data acquisition package for reading data from an Arduino via USB serial on a Raspberry Pi
6 stars 3 forks source link

Use the print function rather than the print statement to be forward-compatible #2

Closed jlsalmon closed 8 years ago

jlsalmon commented 8 years ago

Python 3 doesn't have a print statement, only a builtin function. See here

quixoft commented 8 years ago

Loads of people are still on 2.7, be careful. What version is on the pi by default. Ubuntu 14.04 is still on 2.7

jlsalmon commented 8 years ago

Note at the top of the file:

from __future__ import print_function

See here about how __future__ works

quixoft commented 8 years ago

Ok, I hadn't used future before, if we include that we should be sure to test it on both versions. Just in case

jlsalmon commented 8 years ago

It works in all versions greater than 2.6.0, it's universally used

jlsalmon commented 8 years ago

OK to merge?

quixoft commented 8 years ago

Yea looks harmless

On Mon, May 9, 2016, 23:14 Justin Lewis Salmon notifications@github.com wrote:

OK to merge?

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/CosmicPi/cosmicpi-daq/pull/2#issuecomment-217991987

Julian Lewis Mobile: +33646447515

quixoft commented 8 years ago

Whoops sorry about email...