cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Add helm-rg-from-isearch #15

Closed tohammer closed 5 years ago

tohammer commented 5 years ago

Allows call helm-rg with current isearch string.

cosmicexplorer commented 5 years ago

Hello, thanks again for the contribution!

I have dived more into testing and came up with something that seems to accurately test this change in 9315e5ef146c4b465c047f25f6e54a26f503a560. I also set the interactive testing to run in travis, so once travis gets around to running that we should see it fail (and then we should be able to see this change make it turn green). As in #14, could you rebase against that commit and let me know if test-helm-rg/helm-rg-from-isearch passes locally for you?

Thanks again!

tohammer commented 5 years ago

I can confirm that this test also works as expected

cosmicexplorer commented 5 years ago

As in #14, this is a supremely useful feature (and I use isearch quite a bit already too)! Thanks again for reaching out and making this contribution!