search

cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Build error with helm-rg in emacs25 and emacs26 #19

Closed JohnC32 closed 4 years ago

JohnC32 commented 4 years ago

When trying to byte-compile helm-rg and get see errors. Is this an issue with the way I'm byte-compiling or something else? I'm using helm-rg.el https://github.com/cosmicexplorer/helm-rg/commit/2cac4b6f9ab16962d63003c3f8b07e4d4f9899db from Jan-30-2019

Repro on Linux (Debian 9):

mkdir helm-rg
cd helm-rg
dowload helm-rg.el 

emacs25 --version
GNU Emacs 25.1.1

emacs25 -batch -Q $LOAD_PATH25 -f batch-byte-compile helm-rg.el
In toplevel form:
helm-rg.el:265:1:Error: Unknown helm-rg-cl-typep pattern: (helm-rg-cl-typep keyword)

emacs26 --version
GNU Emacs 26.3
In toplevel form:
helm-rg.el:265:1:Error: Symbol’s function definition is void: helm-rg-cl-typep--pcase-macroexpander

where LOAD_PATH25 and LOAD_PATH26 contain -L /path/to/async -L /path/to/helm -L /path/to/dash.

I saw https://github.com/cosmicexplorer/helm-rg/issues/6 which seems like a similar issue.

JohnC32 commented 4 years ago

I realized the problem. I need to add -l helm-rg.el when building.