cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Stop getting results #26

Closed olymk2 closed 4 years ago

olymk2 commented 4 years ago

So recently I have stopped getting results, not sure if this is due to an updated package or something, is there a nice way to debug why i get no results ?

manually moving to the folder in a shell and writing out the command from helm-rg works.

$ emacs --version
GNU Emacs 26.3
$ /usr/bin/rg --version
ripgrep 12.1.0
-SIMD -AVX (compiled)
+SIMD +AVX (runtime)

image

hankmander commented 4 years ago

I recently ran into the same issue and it seems to be that helm-rg is incompatible with the latest version of helm. I downgraded to helm 3.6.1 and it worked again: https://github.com/emacs-helm/helm/releases/tag/v3.6.1

TimQuelch commented 4 years ago

I just did a bisect of helm and it appears to have broken in https://github.com/emacs-helm/helm/commit/4071dca7f80b590a9d089ff790fb54224fad110d

olymk2 commented 4 years ago

@hankmander thanks for that info, guessing that means helm-rg needs to be patched to the newer helm, or is it a bug in helm ? I will try downgrading for now anyway.

TimQuelch commented 4 years ago

I suspect it is something to do with this change here

https://github.com/emacs-helm/helm/commit/4071dca7f80b590a9d089ff790fb54224fad110d#diff-8c8f72d1065ad18ee00c7ada381eb897R1567-R1578

but I'm not too sure tbh

olymk2 commented 4 years ago

I just noticed there is a PR open which might be related https://github.com/cosmicexplorer/helm-rg/pull/25

seokbeomKim commented 4 years ago

@olymk2 Yes it is. I've just tested that this issue has been solved after applying the PR code.

cosmicexplorer commented 4 years ago

I really appreciate the involved investigation here to solve a problem I'd been having a lot of difficulty with!! As of #25 being merged, I believe @braineo has fixed the issue as confirmed above by @seokbeomKim (thank you!!). Thank you also to @olymk2 for the very very detailed bug description!

Please reopen this issue if this failure recurs, or another issue for any new failures ^_^