cmccloud
commented
6 years ago Also, bounce seems to fail to read the updated directory in a search that is rerun from a new directory using M-d.
Open cmccloud opened 6 years ago
cmccloud
commented
6 years ago Also, bounce seems to fail to read the updated directory in a search that is rerun from a new directory using M-d.
cosmicexplorer
commented
6 years ago I'll take a look right now! I would love to contribute to an existing project if possible. "bounce mode" is "experimental" right now, until I add testing (soon, if wgrep-helm works well enough), but I will look into the issue you described with using M-d after that.
cosmicexplorer
commented
6 years ago So after looking through wgrep and its frontends, the main issue I see with using that code is that the contents seem to come directly from the command's output, while most of the development on "bounce mode" has been to make it a much more active editing interface, allowing:
Most of the "bounce mode" development I see as being something that could be layered on top of wgrep, as I see it, to add this kind of "live editing" or whatever. wgrep seems to have many frontends (including a helm one), but not a ripgrep one, which is very interesting. I'll absolutely keep a close eye on that package -- as of now the current development seems like it might be orthogonal to wgrep and thinking about how this would slot into that is very interesting. Thanks a lot for pointing it out!
cosmicexplorer
commented
6 years ago Also, bfc3a16bbc00f808b319a070c6fcbd37f32ee8e9 should have fixed the M-d issue! I just made sure to change to the directory using the variable we're already using for the helm buffer.
Really enjoying how this is coming along. Just got the latest build, and I thought that maybe before spending too much more time on helm-rg--bounce, it would be worth it to take a look at how helm-grep-do-ag does it with wgrep-helm. It might be easier to just format helm-rg results appropriately and let wgrep-helm handle it from there. Take care.