cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

New ripgrep format breaks helm-rg #39

Open lytex opened 10 months ago

lytex commented 10 months ago

Ripgrep has changed the format of the urls and this breaks helm-rg. It now includes hostname and user name

For example the query: /usr/bin/rg --smart-case --color=ansi --colors=match:fg:red --colors=match:style:bold "empower your writing with emacs org-mode" ~/org

Old format:
/home/user/org/roam/20210812120549-literate_programming.org:** [[https://www.offerzen.com/blog/literate-programming-empower-your-writing-with-emacs-org-mode][Literate Programming: Empower Your Writing with Emacs Org-Mode - OfferZen]]

New format:
]8;;file://hostname/home/user/org/roam/20210812120549-literate_programming.org\/home/user/org/roam/20210812120549-literate_programming.org]8;;\:** [[https://www.offerzen.com/blog/literate-programming-empower-your-writing-with-emacs-org-mode][Literate Programming: Empower Your Writing with Emacs Org-Mode - OfferZen]]

This in turn breaks file paths, and helm-rg cannot jump to the right file. Instead it prompts the user to create some jumbled up directory: home/user/org/]8;;file://hostname/home/user/org/roam/20210812120549-literate_programming.org\roam/

Old format: image

New format: image

It seems the commit introducing the change is https://github.com/BurntSushi/ripgrep/commit/1a50324013708e3c73bfa986d273af2f8e8e3360

Currently this commit it is not part of a released ripgrep version, but some day it will be the current one.

lytex commented 4 months ago

There is now a pull request #40, not yet tested