search

cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Don't kill `*helm-rg*` buffer after `helm-rg` #4

Closed xiongtx closed 6 years ago

xiongtx commented 6 years ago

helm-rg--unwind-cleanup kills the *helm-rg* buffer after invocation of helm-rg. This prevents helm-resume from working.

helm-resume can resume a previous Helm session without re-running the command, allowing the user to pick up where they left off. This can be useful when it's not clear which of several search results is the one desired.

cosmicexplorer commented 6 years ago

I just pushed 87c09d58f427be9b3fb82d6855f9f76499eee2de, which should do the trick. I left a TODO because this sort of thing deserves a test. I plan to invest a little more time developing "bounce mode" before adding testing, but it's something I've done before and shouldn't take too long after that. If there are further interactions with other packages I should fix or note, please let me know! Thanks for the clear and detailed issue.

xiongtx commented 6 years ago

Looks good!