cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Missing argument when checking default directory #5

Closed svedin closed 6 years ago

svedin commented 6 years ago

I tried to have helm-rg open with a specific default directory doing something like this

(defun run-rg-in-specific-dir()
  (interactive)`
  (let ((helm-rg-default-directory "<some path>"))`
    (helm-rg "")))

but got an Wrong number of arguments error. I tracked it down to the helm-rg--interpret-starting-dir function with seems to be missing an argument. So i added it :)

cosmicexplorer commented 6 years ago

Wow, thanks a lot! I've been adding notes where things need to be tested, and this is just one example (defcustoms that I don't use enough). I will add a note for this one as well.

Please feel free to file any further issues or PRs in the future!

cosmicexplorer commented 6 years ago

Have just pushed 6983811 as well, which adds a note about testing this method.