search

cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

error in process filter: pcase--macroexpand: Unknown rx pattern: (rx (: bos eos)) error in process filter: Unknown rx pattern: (rx (: bos eos)) #6

Open WorldsEndless opened 6 years ago

WorldsEndless commented 6 years ago

Just installed helm-rg and installed rg. Commandline rg works fine. Attempting helm-rg makes this error:

error in process filter: pcase--macroexpand: Unknown rx pattern: (rx (: bos eos))
error in process filter: Unknown rx pattern: (rx (: bos eos))
andrunix commented 6 years ago

I have been using rg for a while now. Just tried installing helm-rg and during install I get a similar error:

helm-rg.el:256:1:Error: Symbol’s function definition is void: helm-rg-cl-typep--pcase-macroexpander

I have no clue.

cosmicexplorer commented 6 years ago

Hey, this was entirely my fault and what I was trying hard but not hard enough to avoid when playing with macros. I will look into this today. Thanks a lot for the report, and I'm really sorry for the breakage! See #8 -- I'm planning to add automated testing very soon so this won't happen again.

cosmicexplorer commented 6 years ago

I believe I should have resolved both of the issues each of you have described. I have added Travis CI to the repository, and will add deeper testing with ert later. In the process of setting up Travis, I encountered both of the issues you described. Since Travis is passing with emacs 25.1, 25.2, 25.3, and 26.1, I believe I should be able to maintain an unbroken master (especially as I start adding testing), and you should not have to worry about this occurring again.

Thanks so much for the report (both of you)! Please let me know if the issue continues to occur. It may take up to a day for the package to propagate to MELPA, however, so you can also try pulling from this repository if you want to check earlier.

cosmicexplorer commented 6 years ago

The helm-rg-cl-typep--pcase-macroexpander was I believe because I defined my macros in the wrong order, and this failed during byte compilation. The (rx (: bos eos)) error occurred because the rx pcase macro uses (gensym) internally, and I hadn't been loading subr. I experienced errors loading subr, which was weird, but I ended up resolving it by replacing the rx pcase macro with a string-match call, which is all that rx macro was trying to do anyway. I have left a comment describing the issue for future reference.

cosmicexplorer commented 5 years ago

I have started adding deeper testing to support the changes in #14 and #15, so this sort of error shouldn't occur again -- if it does, please feel free to leave an issue and we can work out testing for it.

cosmicexplorer commented 5 years ago

Actually, reopening this as running make install-packages fails if helm-rg is added to the list of packages to install with this exact error (and this also occurs for me now when running (package-install 'helm-rg), not sure if it was failing before or if I wasn't paying enough attention). Will look into fixing this now that I have a repro!