search

cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

Added require for subr-x, prefixed incf calls with cl- #8

Closed jasonrobot closed 6 years ago

jasonrobot commented 6 years ago

Fixes #7, plus another nil function that I found when testing with a minimal init.el

cosmicexplorer commented 6 years ago

Thanks so much for the thorough testing and PR! I have screwed around with automated testing quite thoroughly when I was contributing to markdown-mode, and as I just managed to push a broken change to master it sounds like the right time to start that here! I'll try to delve into that this weekend.

cosmicexplorer commented 6 years ago

Hey, just wanted to let you know that I have added Travis CI to this repository, testing emacs versions 25.1, 25.2, 25.3, and 26.1. This should (by byte-compiling the file) prevent issues like this from occurring again (and there were many, many issues I fixed to get it to work on Travis). I will be adding actual testing with ERT later today or this weekend.

Thanks again for the PR!

jasonrobot commented 6 years ago

No problem, happy to help! Sounds like a good idea - I've been looking for a good way to test my elisp code, but mostly been doing it manually. I'll have to look in to ERT