search

cosmicexplorer / helm-rg

ripgrep is nice
GNU General Public License v3.0
101 stars 21 forks source link

[feat] show results in grep buffer #9

Closed bomgar closed 5 years ago

cosmicexplorer commented 6 years ago

Hello! Thanks for the contribution!

I'm sorry for the extended delay responding, I've been very sick recently. I think this change is idiomatic and makes sense.

However, are you familiar with the (admittedly still unstable) helm-rg--bounce function (reachable from the helm results buffer with M-b? It seems to have the output in a very similar arrangement to your contribution here, and also allows e.g. jumping to each line in the source file (along with many other currently-evolving features!).

Is there a use case for the grep-mode buffer created in this PR, or could some of its utility be potentially merged into the existing "bounce" mode?

I am probably fine with merging this PR as is, I just would like to know your thoughts on the above.

Thanks again for the contribution!

bomgar commented 6 years ago

I didn't know this exists. I'm used to the extra buffer from helm-ag. I guess the bounce mode is good enough for my use case.

The argument for the grep mode would be: A lot of emacs plugins use it and users have a configuration for it. Which means they are familiar with the behavior and keybindings. No need to reinvent the wheel.

As I said I don't really need it now that I know bounce exists. Thanks for reviewing this.