search

cosmicnebula200 / SellMe

The Ultimate Sell plugin for PocketMine-MP 4
GNU General Public License v3.0
1 stars 12 forks source link

Update to pm5 #8

Closed ghost closed 1 year ago

ghost commented 2 years ago

It would be a good plugin in pm5

cosmicnebula200 commented 2 years ago

Hello @SrBanYT2143,

Thanks for the suggestion, but I dont think so doing this will be a great idea as of today (due to the fact that none of the Economy Providers are actually updated to PM5). A sell plugin without an actual economy plugin would be meaningless and hence will not be something I would put my time on updating.

PM5 isnt that much code breaking updating to it shouldnt take as long as pm3->pm4 updates so I am sure it wont be long for the economy plugins to be updated once PM5 is officially out.

Tbh I am planning on to continue to maintain this even for PM5 . Even if one of the Economy Providers (EconomyAPI/BedrockEconomy/Capital) is updated to PM5 I will also be dropping a branch just to support PM5.

ghost commented 2 years ago

there was not much change in the economy plugin, at least in "BedrockEconomy" it is working perfectly in pocketmine 5 after api change in plugin.yml

I understand your side, I use this plugin on pocketmine 4 but I'm updating my server so when pocketmine 5 launches I open my server peacefully. No and many who agree.

ghost commented 2 years ago

Could open a branch for pocketmine 5

cosmicnebula200 commented 2 years ago

Could open a branch for pocketmine 5

Sure! I will prolly do it in a few weeks