search

cosmicrays / hermes

HERMES is a publicly available computational framework for the line of sight integration over galactic radiative processes which creates sky maps in the HEALPix-compatibile format.
GNU General Public License v3.0
22 stars 9 forks source link

problem with Grid2D #33

Closed carmeloevoli closed 1 year ago

carmeloevoli commented 1 year ago

Grid2D is still based on Vector3D, which is clearly inconsistent. Still it is used only for reading Dragon maps, so it is not an issue now but it might be for future users.

adundovi commented 1 year ago

Why this should be an issue? We just ignore one dimension in 3D to get 2D?

carmeloevoli commented 1 year ago

Does it work correctly also for rotation and all the operations?

adundovi commented 1 year ago

I don't know by heart, but if it doesn't we should fix it there. I would avoid re-implementing new vector class for 2D since the most vector properties are the same with 3D.

carmeloevoli commented 1 year ago

agree.