search

cosmicsilence / gradle-scalafix

Gradle plugin for Scalafix
BSD 3-Clause "New" or "Revised" License
26 stars 5 forks source link

fix in source set compile task doFirst action definition used for semantic db configuration #59

Closed fsanjuan closed 10 months ago

fsanjuan commented 2 years ago

Fix for https://github.com/cosmicsilence/gradle-scalafix/issues/58

aishfenton commented 2 years ago

Not sure if you also want to look at this as part of it too. https://github.com/cosmicsilence/gradle-scalafix/issues/58#issuecomment-987490084

Thankfully the plugin option has an easy workaround (i.e. using Gradle's scalaCompilerPlugin mechanism instead of setting the option). But the sourceroot part is still puzzling me. I was hoping maybe it could just be removed (since according to the semanticdb docs, all it does is relativize the paths), but without it the generated semenaticdb files aren't even appearing in the build directory. So quite confused by that.

fsanjuan commented 2 years ago

Not sure if you also want to look at this as part of it too. #58 (comment)

Thankfully the plugin option has an easy workaround (i.e. using Gradle's scalaCompilerPlugin mechanism instead of setting the option). But the sourceroot part is still puzzling me. I was hoping maybe it could just be removed (since according to the semanticdb docs, all it does is relativize the paths), but without it the generated semenaticdb files aren't even appearing in the build directory. So quite confused by that.

👋 Apologies for the late reply. I just read your comments there :)

Let's keep this PR to upgrade the plugins and fix that conditional doFirst action. We will work on that in a new one :D

marcelocenerine commented 2 years ago

could you take a look at this comment before merging the PR?

marcelocenerine commented 10 months ago

Closing this PR since there's been no activity lately. I will resume the work in a new PR.