search

cosmin42 / cpp-photobook

Photo books editing software - Excercise for cpp skills development
Other
1 stars 0 forks source link

Cosmin/persistence refactory polished #71

Closed cosmin42 closed 2 months ago

cosmin42 commented 2 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes involve significant modifications across multiple files in the codebase, focusing on the removal of several persistence-related classes and methods, as well as the restructuring of various components to enhance project management capabilities. Key updates include the integration of ProjectId and PaperSettings in the ImageToPaperTask class, the introduction of a ProjectManagementSystem, and a shift from persistence services to project management functionalities. The overall architecture reflects a move towards a more modular design with streamlined dependencies.

Changes

Files Change Summary
PB/CMakeLists.txt Removal of multiple header and source files related to image processing and persistence.
PB/include/pb/Command.h, PB/include/pb/ImageMonitor.h, PB/include/pb/ImageToPaperTask.h, PB/include/pb/ImportFoldersLogic.h, PB/include/pb/PhotoBook.h, PB/include/pb/PhotobookListener.h, PB/include/pb/Platform.h, PB/include/pb/StagedImages.h, PB/include/pb/WorkersManager.h, PB/include/pb/export/Exportable.h, PB/include/pb/export/Html.h, PB/include/pb/export/Pdf.h, PB/include/pb/image/Image.h, PB/include/pb/image/ImageFactory.h, PB/include/pb/image/ImageOperations.h, PB/include/pb/image/ImageReader.h, PB/include/pb/image/ImageSetWriter.h, PB/include/pb/image/VirtualImage.h, PB/include/pb/persistence/FilePersistence.h, PB/include/pb/persistence/Persistence.h, PB/include/pb/persistence/PersistenceService.h, PB/include/pb/persistence/SQLPersistence.h, PB/include/pb/persistence/SerializationStrategy.h, PB/include/pb/project/PaperSettings.h, PB/include/pb/project/Project.h, PB/include/pb/project/ProjectMetadata.h, PB/include/pb/tasks/ParallelTaskConsumer.h, PB/include/pb/tasks/SequentialTaskConsumer.h, PB/include/pb/tasks/Tasks.h, PB/include/pb/tasks/ThumbnailsProcessor.h, PB/include/pb/util/Util.h Removal of various classes and methods related to persistence; refactoring of classes to utilize ProjectManagementSystem and new project management methods.
PB/src/FilePersistence.cpp, PB/src/ImageSetWriter.cpp, PB/src/Persistence.cpp, PB/src/PersistenceService.cpp, PB/src/SQLPersistence.cpp, PB/src/util/SequentialTaskConsumer.cpp Complete removal of persistence-related implementation files, indicating a significant change in how persistence is managed.
PB/src/ImageOperations.cpp, PB/src/PhotoBook.cpp, PB/src/PaperSettings.cpp, PB/src/ProgressManager.cpp Refactoring and updates to utilize new dependencies and methods; adjustments to streamline functionality.
PB/tests/TestComparator.cpp, PB/tests/TestErrors.cpp, PB/tests/TestIteratorWithState.cpp Modifications to test files to reflect changes in dependencies and focus on error handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProjectManagementSystem
    participant ImageFactory
    participant ImageToPaperService
    participant ThumbnailsProcessor

    User->>ProjectManagementSystem: Create Project
    ProjectManagementSystem-->>User: Project Created
    User->>ImageFactory: Configure with ProjectManagementSystem
    ImageFactory->>ImageToPaperService: Map Image to Project
    ImageToPaperService->>ThumbnailsProcessor: Generate Thumbnails
    ThumbnailsProcessor-->>ImageToPaperService: Thumbnails Generated
    ImageToPaperService-->>User: Process Completed

🐰 "In the garden where changes bloom,
New paths are carved, dispelling gloom.
Projects managed with a hop and a skip,
Images dance, on a joyful trip.
With every refactor, we leap and cheer,
For a brighter future, drawing near!" 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.