cosmir / openmic-2018

Tools and tutorials for the OpenMIC-2018 dataset.
MIT License
91 stars 10 forks source link

audio waveform normalization inconsistency #34

Open ejhumphrey opened 5 years ago

ejhumphrey commented 5 years ago

I've been checking our math given fresh eyes from the passage of time, and it seems like we (I) have been inconsistent as to when the audio signal gets normalized (scaled within [-1, 1]). In the initial work (the InstrumentDNN), all audio was scaled prior to waveform_to_examples. Now it looks like we're only doing that for the user if they come in through soundfile_to_examples... but not the other ones.

I'd propose the following corrective action:

ejhumphrey commented 5 years ago

thoughts @bmcfee ?

bmcfee commented 5 years ago

i see your point -- since normalization is (should be) idempotent, i think it makes more sense to do it as close to processing as possible (ie inside waveform_to_examples) as you suggest.