search

cosmo-team / cosmo-issues

Issue repository for Cosmo (separate until we can transfer issues between repositories nicely - ignore code)
http://www.github.com/cosmo-team/cosmo
GNU General Public License v3.0
0 stars 0 forks source link

Merge and integrate KMC fork #141

Closed alexbowe closed 8 years ago

alexbowe commented 8 years ago

The reason the codebase is fractured is because GitHub doesn't allow a user to fork their own repository. I wanted to do so to have a public repo, but still be able to make private changes for unfinished papers in a separate, private repo.

GitHub teams might fix this. Create single public repository with long-term tickets and minor bug fixes as tickets. Then for each paper (where we want to make private changes until publication), a user can create a private fork with its own issues.

Integration will need to be done by publication anyway, and this will improve our workflow, so it should probably be done ASAP. I'm thinking after I finish #12 and #20 (so the private branch is in a compatible working state).

Would be really nice to handle dependencies better too... maybe with biicode or docker? Also, fixing compiler warnings and so on...

mmuggli commented 8 years ago

SDSL-Lite uses biicode, FWIW.

This might be a solution: https://24ways.org/2013/keeping-parts-of-your-codebase-private-on-github/

alexbowe commented 8 years ago

Yup. I actually think both of these would be useful.

Docker would let people use the code (and replicate our experiments) super easily with almost no overhead on Linux ( http://domino.research.ibm.com/library/cyberdig.nsf/papers/0929052195DD819C85257D2300681E7B/$File/rc25482.pdf) but there is a slowdown on Windows and Mac (it has to run through a VM), so users of those would have to compile if they wanted performance - which biicode would help with.

Mac and Windows are currently hard to compile for (differences in openmp support, + some other stuff). Docker would be a nice first step to ensure easy reproducibility and identical dev environments. Biicode can come a bit later when we want to support production use on Mac.

I had a quick look through the link (thanks!). It looks similar to what Shaun Jackman (abyss dev) recommended to me. It is kinda confusing for me with branches and pull requests in two repositories (and sure I could learn git better, but if the public master repo idea is easier it might attract more open source devs).

On Thu, 18 Feb 2016 at 08:12 Martin Muggli notifications@github.com wrote:

SDSL-Lite uses biicode, FWIW.

This might be a solution: https://24ways.org/2013/keeping-parts-of-your-codebase-private-on-github/

— Reply to this email directly or view it on GitHub https://github.com/alexbowe/cosmo-private/issues/141#issuecomment-185471720 .

alexbowe commented 8 years ago

Depends on #12, as cosmo-pack.cpp has been vastly modified on separate branches, it is a little hard to merge.

alexbowe commented 8 years ago

Merged, but need to work out why cosmo-color isn't outputting anything. Might be my changed graph representation. Working on unit tests first since checking/rechecking the graph API is really annoying.

alexbowe commented 8 years ago

Blocked by #172.