cosmo0920 / win32-api

A different, better variant of the Win32API Ruby library
61 stars 10 forks source link

Use ULONG2NUM() for API.last_error to avoid truncate #58

Closed ashie closed 3 years ago

ashie commented 3 years ago

The return value of GetLastError() is DWORD so INT2NUM() isn't appropriate. Sorry for my careless.

ashie commented 3 years ago

@cosmo0920 ping

cosmo0920 commented 3 years ago

On ruby-head, some SEGV is happened but it is not our fault: https://github.com/cosmo0920/win32-api/pull/58/checks?check_run_id=2386539637#step:5:129

cosmo0920 commented 3 years ago

I'd published this patch as v1.10.1. https://rubygems.org/gems/win32-api/versions/1.10.1

ashie commented 3 years ago

Thanks!