search

cosmo0920 / windows-pr

A collection of Windows functions, constants and macros predefined for you for win32-api
23 stars 9 forks source link

Rakefile line correction? #22

Open MSP-Greg opened 7 years ago

MSP-Greg commented 7 years ago

Should Rakefile line 37

t.test_files = FileList[file]

be changed to --

t.test_files = FileList['test/helper.rb', file]

Saw your issue Bug #13746. I'm getting different results with a ruby_2_4 64 bit MinGW build. But, I'm using win32-api 1.4.8.

For instance, I think you showed a SEGV, but I got the following:

rake test:ntfs_winternl --trace

** Invoke test:ntfs_winternl (first_time)
** Execute test:ntfs_winternl
Run options: --seed 40551

# Running:

.E:/r_builds/24_2017-07-23_59409/ruby24_64/lib/ruby/gems/2.4.0/gems/windows-pr-.2.6/test/tc_ntfs_winternl.rb:39: warning: constant ::Fixnum is deprecated
F..

Finished in 0.018165s, 220.1998 runs/s, 275.2497 assertions/s.

  1) Failure:
TC_Windows_NTFS_Winternl#test_get_final_path_name_by_handle_returns_expected_result [E:/r_builds/24_2017-07-23_59409/ruby24_64/lib/ruby/gems/2.4.0/gems/windows-pr-1.2.6/test/tc_ntfs_winternl.rb:40]:
Expected: # encoding: UTF-8
"winternl_test.txt"
  Actual: # encoding: US-ASCII
""

4 runs, 5 assertions, 1 failures, 0 errors, 0 skips
rake aborted!

More later. I'll check trunk also...

cosmo0920 commented 7 years ago

Many thanks to pay attention to bugs.ruby-lang.org#13746 and SEGV issue. This is for i386 Ruby 2.4 issue not for x86_64.

MSP-Greg commented 7 years ago

You're welcome. Sorry, I didn't run it thru google translate, and I saw '32/64bit'. Normally, I just build 64 bit...

cosmo0920 commented 7 years ago

windows-pr gemのCI対象にRuby 2.4 32/64bit版の両方を加えてAppVeyorにてCIを走らせたところ、SEGVが発生しました。 このSEGVはRuby 2.4の64bit版（ruby 2.4.1p111 (2017-03-22 revision 58053) [x64-mingw32]）では発生しません。

windows-prのリポジトリは https://github.com/cosmo0920/windows-pr です。 git clone後、bundle install && bundle exec rake test:allでテストが走るようになっています。

SEGVの内容は以下の通りです。

means:

When I added Ruby 2.4 32bit and 64 bit into CI target and then run CI for windows-pr gem, I got a SEGV. This is not caused by Ruby 2.4 64bit, but caused by Ruby 2.4 32bit. They are mingw32 ABI.

Currently, windows-pr is developed in https://github.com/cosmo0920/windows-pr. (Because this is transferred ownership project. I'm not an original author.) You can confirm this issue with git clone, bundle install, and bundle exec rake test:all.

SEGV stack trace is as follows:

Note that Japanese speaker usually tend to say briefly, I also do unconsciously. Sorry for unclear bug report.

MSP-Greg commented 7 years ago

Actually, my fault for not translating. I think 'saying briefly' is common with coders.

I've been working on MinGW trunk builds for a while, but recently decided to build ruby_2_3 & ruby_2_4 stable branches. Once I get that working consistently, bug reports filed (I think some backports may have been missed), etc, I may try to run tests on this repo...

Thanks for your work.