Make sure ACL fields are searched 'as-is'

cosmocode / dokuwiki-plugin-elasticsearch

Integrate an external Elasticsearch engine into DokuWiki

https://www.dokuwiki.org/plugin:elasticsearch

4 stars 6 forks source link

Make sure ACL fields are searched 'as-is' #6

Closed annda closed 4 years ago

annda commented 4 years ago

ACL fields must NOT be indexed as natural language, with word splitting etc. but this is what standard mapping results in. This PR explicitly defines simple keyword mapping for those fields, which will prevent that behavior.

This PR could fix #3 if the user's problem is caused by special characters in usergroup names.

annda commented 4 years ago

The changes in this PR require not only re-indexing, but re-creating the whole index. @splitbrain do you think this is a problem?

splitbrain commented 4 years ago

I think it's fine. should be explicitly mentioned in the docs.

for a better fix, maybe we can keep an index version somewhere and warn about an outdated index?