cosmocode / dokuwiki-plugin-filelisting

Shows a listing of all the files in the current namespace und subnamespaces below the page
2 stars 3 forks source link

Plugin Outline #1

Closed micgro42 closed 1 year ago

micgro42 commented 7 years ago

A plugin is to be developed, which lists all the media files present in the current namespace (of the currently viewed page).

2017-10-11 14 26 56

Note: If the Drag'n'Drop plugin is installed, files can also be dragged directly to the file list to trigger an upload without having to edit the current page. If files are dragged to a subnamespace, they are uploaded there instead of being uploaded to the current namespace. (This will be implemented in the Drag'n'Drop plugin and is not part of this ticket).

Estimation: 3 days

micgro42 commented 7 years ago

cc @solewniczak

solewniczak commented 7 years ago

Sounds reasonable. 24 hours should be enough time. Subnamespaces should be expanded using ajax call or it will be enough to load everything during page load?

splitbrain commented 7 years ago

Yes, Ajax requests for the sub namespaces.

solewniczak commented 7 years ago

Ok, does the plugin need to work without JavaScript too?

splitbrain commented 7 years ago

basic stuff like showing the current namespace files should work, but all additional stuff like filtering, sorting or subnamespaces are fine to require JS

solewniczak commented 7 years ago

I've implemented basic html view. Check commit message for some design decisions I've made.

splitbrain commented 7 years ago

Looks good so far :+1:

solewniczak commented 7 years ago

Should the filtering work only for the current namespace or for all sub namespaces too? For all sub namespaces the ajax call becomes useless since we need to load all media files in advance.

The solution which I believe is the most elegant is filtering only on expanded namespaces. I'll implement it this way but if you want it to work differently let me know.

splitbrain commented 7 years ago

yes, filtering should only apply to the currently open namespaces

solewniczak commented 7 years ago

Ok, I've just finished the plugin. Waiting for feedback.

micgro42 commented 7 years ago

I like it! :+1:

There are some minor issues and a follow-up requirement. I will open tickets for each of those.