search

cosmocode / dokuwiki-plugin-oauth

Generic oAuth1 and oAuth2 plugin for DokuWiki
http://www.dokuwiki.org/plugin:oauth
30 stars 78 forks source link

Update github oauth to use Authorization HTTP header #85

Closed djgalloway closed 3 years ago

djgalloway commented 4 years ago

GitHub has deprecated the use of the access_token query parameter.

https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

auto-comment[bot] commented 4 years ago

Thank you for opening this issue. CosmoCode is a software company in Berlin providing services for wiki, app and web development. As such we can't guarantee quick responses for issues opened on our Open Source projects. If you require certain features or bugs fixed, you can always hire us. Feel free to contact us at dokuwiki@cosmocode.de for an offer.

tmo26 commented 4 years ago

I'm also interested in getting this issue resolved, since sooner or later github will stop accepting this deprecated parameter, which then will render logins via OAuth / github inoperable.

Lineflyer commented 4 years ago

Update on the depracation note on Github. Time is ticking: https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/

splitbrain commented 4 years ago

A pull request would be most welcome.

thess commented 4 years ago

@splitbrain - take a look at #90 for a PR.