cosmocode / edittable

Plugin to provide a custom editor for tables in DokuWiki
https://www.dokuwiki.org/plugin:edittable
32 stars 26 forks source link

Can't save edited tables after switching to php-7.3 #165

Closed pornmailbox closed 5 years ago

pornmailbox commented 6 years ago

[error] 1160#1160: *138 FastCGI sent in stderr: "PHP message: PHP Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/localhost/htdocs/dokuwiki/lib/plugins/edittable/action/editor.php on line 129PHP message: PHP Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/localhost/htdocs/dokuwiki/lib/plugins/edittable/action/editor.php on line 130PHP message: PHP Warning: Illegal string offset 'align' in /var/www/localhost/htdocs/dokuwiki/lib/plugins/edittable/action/editor.php on line 140PHP message: PHP Fatal error: Uncaught Error: Cannot use string offset as an array in /var/www/localhost/htdocs/dokuwiki/lib/plugins/edittable/action/editor.php:147

janlinde commented 5 years ago

Same here, PHP 7.2.11. Reverting commit splitbrain/dokuwiki@2145bd4c56435f829a19aad843172f8ddffbc69b makes the problem go away.

splitbrain commented 5 years ago

probably fixed by https://github.com/splitbrain/dokuwiki/pull/2686