search

cosmocode / edittable

Plugin to provide a custom editor for tables in DokuWiki
https://www.dokuwiki.org/plugin:edittable
32 stars 26 forks source link

less code not translateable? #179

Closed lpaulsen93 closed 5 years ago

lpaulsen93 commented 5 years ago

I noticed that some portions of edittable/lib/handsontable.less do not seem to be translated into valid CSS code. The CSS code of a DokuWiki page e.g. includes the following if the edittable plugin is installed and enabled:

@keyframes wtFadeInFromNone{0%{display:none;opacity:0;}1%{display:block;opacity:0;}100%{display:block;opacity:1;}}
@-webkit-keyframes wtFadeInFromNone{0%{display:none;opacity:0;}1%{display:block;opacity:0;}100%{display:block;opacity:1;}}

P.S.: This breaks CSS loading/interpreting in the ODT plugin as my parser is not expecting less code in CSS files. It would be nice if this could be fixed :grin:

At least this looks like less code to me. Please correct me if I am wrong or have overseen something.

splitbrain commented 5 years ago

This is actually not less but valid CSS (it's used to define CSS animations) You may want to simply strip or ignore these.

lpaulsen93 commented 5 years ago

Ahh...thanks, did not know that. I assumed it was less code because of the nested {...}. But I found a description at https://www.w3schools.com/css/css3_animations.asp.

You may want to simply strip or ignore these.

Well, as it's valid CSS I consider this a bug in my CSS parser. So I will have to address it. Sorry for the false ticket.

lpaulsen93 commented 5 years ago

A little update: the issue in the ODT plugin is fixed, see https://github.com/LarsGit223/dokuwiki-plugin-odt/issues/245.