cosmocode / edittable

Plugin to provide a custom editor for tables in DokuWiki
https://www.dokuwiki.org/plugin:edittable
32 stars 26 forks source link

Save button disappears #86

Closed havarha closed 7 years ago

havarha commented 9 years ago

I use edittable and the starter bootstrap template (https://www.dokuwiki.org/template:starterbootstrap). Everything has been working fine until the other day, when I was editing a table of 48 rows. When adding a new row, editing a value in an existing cell etc the save button would disappear, and some of the other buttons would also move up on the page or disappear.

I guess this could also be a template plugin, but this has worked perfectly for a long time, and I haven't updated the template. I did update the plugin today, but that didn't help.

Any clue why this could be happening?

winnuker commented 9 years ago

Same here with large tables.

Firefox (40.0.2) and Chrome (45) with DokuWiki Template: Edit big table 24 Rows are shown. Click on the table -> 37 rows are shown. Click on the table -> 52 rows are shown. Click on the table -> 70 rows are shown. Click on the table -> all 80 rows are shown. The save/preview buttons are visible and usable.

Arctic Template: Edit big table. 57 rows are shown. The table lays over the bottom of the page. No buttons visible. Double clicking on the table shows a few more rows until all 80 rows are shown. The save/preview buttons are under the table and out of reach.

Hope this helps.

stevenj commented 9 years ago

I also have this problem with large tables with the Bootstrap3 Template. Firefox 40.0.0

splitbrain commented 9 years ago

@micgro42 can you have a look at this please?

micgro42 commented 9 years ago

I can reproduce the issue with the three templates.

I would consider the starterbootstrap template to be conflicting / incompatible with edittable, since it seems to also include a sort-column functionality which breaks the movement of columns.

The same functionality that enables the plugin to work well with the dokuwiki template breaks it with the other templates. I will look into adapting the plugin to the other templates or vice versa.

micgro42 commented 9 years ago

I pushed a css fix to editable master which should have fixed the issues here. Please test it and tell me if it improved the situation.

havarha commented 9 years ago

Doesn't seem to help in my case...

stevenj commented 9 years ago

But it does in mine. Bootstrap 3 template now has the Save Buttons/etc pushed below my large table.

havarha commented 9 years ago

I would just like to point out that the buttons are there until I try to change something in the table. After adding a row, editing a value etc the buttons jumps up and disappears behind the table.

havarha commented 9 years ago

Hmmm... It could have been some caching or something in my browser, but it seems to work better now. Now they are almost completely hidden until I change something, and after changing something I can see a bit more than half the height of them.

splitbrain commented 9 years ago

@havarha could you post a screenshot?

havarha commented 9 years ago

Before doing anything:

image

After adding a row:

image

winnuker commented 9 years ago

Thank you very much.

edittable now works fine with DokuWiki template and Arctic template (and big tables).

konus1 commented 9 years ago

Firefox (40.0.2) and Chrome (45) with DokuWiki Template: Edit big table 24 Rows are shown. Click on the table -> 37 rows are shown. Click on the table -> 52 rows are shown. Click on the table -> 70 rows are shown. Click on the table -> all 80 rows are shown.

Is this the normal behavior now? I found it very annoying, because you always have to multiclick to expand the table, before you can save or cancel.

splitbrain commented 9 years ago

@konus1 no. this should be fixed in the dokuwiki template now. What browser and template do you use?

konus1 commented 9 years ago

I use Firefox 40.0.3. Dokuwiki 2015-08-10a "Detritus" with the default Dokuwiki template. I used edittable Version 2015-08-27 and manually now merged commit "Fix table in arctic and bootstrap3 template" into my installation. The behavior did not change.

Where can I find a fixed dokuwiki template? I was searching at https://github.com/splitbrain/dokuwiki but the last change was 5 days ago a translation update.

micgro42 commented 9 years ago

@konus1 The dokuwiki template did not change, but the css in edittable which caused this behaviour changed with the latest commit. However since css is cached both by the browser and by the server you may have to actively clear both caches to see the change.

To clear the dokuwiki cache either touch conf/local.php or simply save your current configuration in the admin menu again, which will also invalidate the dokuwiki cache. You can clear you browser cache by reloading with Shift+F5 or Ctrl+Shift+R or something similar depending on your browser.

konus1 commented 9 years ago

After installing edittable version 2015-09-01 the problem not showing all rows at once is solved for me.Thank you!

micgro42 commented 7 years ago

This seems to be resolved.