Open Zifius opened 9 years ago
Thanks and we would review and make the changes merged into the source code.
Would be merged directly
We need to discuss this in details because status from alipay need to be filtered at the backend by order status.
Would be merged directly
This would be controlled by the backend setting , if website owner want to redirect to alipay directly , we don't need to show this page, but in China customers always confused that the redirection , that's why we have to add this page and popup the alipay's payment page.
Would be merged directly
We need to discuss this in details because status from alipay need to be filtered at the backend by order status.
Oh I understand now the intention. Let's discuss
This would be controlled by the backend setting , if website owner want to redirect to alipay directly , we don't need to show this page, but in China customers always confused that the redirection , that's why we have to add this page and popup the alipay's payment page.
Just to clarify this change was only about moving some order checking logic to Payment.php block but also removal of jQuery, which is not a good change but was needed for the Magento instance I was working on. That must be reverted (actually moved in layout) just didn't have time yet
Understand. We would set the payment page configurable at the backend.
Hi @sidealice, any updates on this PR? Thank you
Dear Zifius,
We would update it in Sep. Sorry the delay was caused by magento2.0's research.
Hello @sidealice, I tried to list all the changes I made. Some of them are pretty tied to the implementation I was working on so we need to discuss and maybe revert some of changes. But at least this will get us going
Also I didn't test unsuccessful payments much
Best, Alex