search

cosmodesi / desilike

BSD 3-Clause "New" or "Revised" License
21 stars 16 forks source link

No functionality of qbao parameter in DirectWiggleSplitPowerSpectrumTemplate #37

Open erikzaborowski opened 3 months ago

erikzaborowski commented 3 months ago

Hi, sometime between now and May 7 (when I was able to successfully train some emulators with qbao), I think the qbao parameter has become broken in DirectWiggleSplitPowerSpectrumTemplate. Here is some code that shows that the theory doesn't vary with qbao, but does vary e.g. with Omega_m:

import numpy as np
from desilike.theories.galaxy_clustering import LPTVelocileptorsTracerPowerSpectrumMultipoles
from desilike.theories.galaxy_clustering import DirectWiggleSplitPowerSpectrumTemplate
template_marg_test = DirectWiggleSplitPowerSpectrumTemplate(z=1.0)
theory_marg_noem_test = LPTVelocileptorsTracerPowerSpectrumMultipoles(template=template_marg_test, prior_basis='physical', tracer='LRG')
np.any(theory_marg_noem_test(qbao=1.0) - theory_marg_noem_test(qbao=1.15) != 0)
np.any(theory_marg_noem_test(Omega_m=0.3) - theory_marg_noem_test(Omega_m=0.35) != 0)

Thank you for any help!

erikzaborowski commented 3 months ago

For what it's worth, the latest commit on DirectWiggleSplitPowerSpectrumTemplate was 97e3b19, and if I checkout the last commit before that one, things work again.

adematti commented 3 months ago

Thanks Erik! --- sorry about this! the last commit should fix it again

erikzaborowski commented 3 months ago

Thanks Arnaud! I'm guessing maybe related to this change, but if I source the cosmodesi env and try import desilike I get a ModuleNotFoundError.