search

cosmodesi / mockfactory

BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

setting los gives error #23

Open zdplayground opened 1 year ago

zdplayground commented 1 year ago

https://github.com/cosmodesi/mockfactory/blob/c55a6b88c2418f8b734672027c487e1f2031974d/mockfactory/gaussian_mock.py#L251

Hi Arnaud, When I tested to generate some lognormal mock with los='z', it gives some error, e.g. ''' 250 if los is not None: --> 251 los = self._get_los(los) 252 self.attrs['los'] = los 253 self.set_complex_delta_field()

AttributeError: 'LagrangianLinearMock' object has no attribute '_get_los'. ''' I guess that we need to change line 251 to "los = _get_los(los)". Could you check it?

Thanks, Zheije

adematti commented 1 year ago

yes, you're right, thanks for the bug report! would you like to submit or PR? or push directly :)

zdplayground commented 1 year ago

Sure, I'm happy to push it. Thanks!