search

cosmodesi / pyrecon

package for BAO reconstruction
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

added save wisdom functionality #11

Closed seshnadathur closed 2 years ago

seshnadathur commented 2 years ago

I have added some features around the wisdom for the fftw FFT engine (addressing #5). The FFTWEngine class now checks that the input wisdom string corresponds to an existing file before trying to load it. This allows BaseReconstruction class to pass a default wisdom filename as argument during initialisation if none is provided. Except in the case that the wisdom input is directly a tuple, the wisdom is always saved to file after creation, either in the file location provided as input, or in a default location if no input is provided. The motivation here is to provide a way to speed up batch runs from the command line without requiring user input for the wisdom, similar to what was achieved in Julian's code.

adematti commented 2 years ago

Hi Sesh, thanks for this PR! Do you want to address the above comments? --- if you don't feel 100% comfortable with how to address them, no problem, I can do this --- just let me know.

seshnadathur commented 2 years ago

I might be missing something obvious, but what comments do you mean?

adematti commented 2 years ago

Sorry, forgot to submit review!