search

cosmodesi / pyrecon

package for BAO reconstruction
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

What is the purpose of output cartesian position column? #3

Closed seshnadathur closed 2 years ago

seshnadathur commented 2 years ago

In the standalone pyrecon code, a ConfigError is raised if the output cartesian position column name is not specified in the config file when the input format is xyz (https://github.com/cosmodesi/pyrecon/blob/main/bin/pyrecon#L285` and https://github.com/cosmodesi/pyrecon/blob/main/bin/pyrecon#L340). But this column name does not appear to be used anywhere. I provided some random name just in order to avoid the error, and the output file produced does not contain it.

So perhaps these checks could be deleted?

adematti commented 2 years ago

You are 100% right, thanks! (probably a remnant of ancient versions...) This should be solved by commit 52417276b1a37004696ee52282542751930643f1.

adematti commented 2 years ago

Can we close the issue?

seshnadathur commented 2 years ago

Yup, this is all good.