cosmoharrigan / rl-glue

Automatically exported from code.google.com/p/rl-glue
0 stars 0 forks source link

Type overhaul --> Observation --> Observation_t #76

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I've always been a little uncomfortable with the typedefs:
Reward
Observation
Action
Terminal
Task_specification
etc.

People are likely to want to use variables by these names, and it's hard to
tell (unless you know apriori) when reading the code, what's a type, what's
a variable.

I recommend we change these to:
reward_t
observation_t
action_t
terminal_t
task_specification_t
etc.

We can actually avoid breaking backward compatibility by having a
"rlglue/legacy.h" file that typedefs the new types to the old types.  If
they include that file, the old type names will work, but maybe we can set
a warning symbol that prints when their ae^2 runs
(agent/environment/experiment).

This is not a terrible amount of work.

Original issue reported on code.google.com by brian.ta...@gmail.com on 7 Sep 2008 at 6:26

GoogleCodeExporter commented 9 years ago
This has been done in r790 and r791.

People can #include <rlglue/legacy_types.h> and all the old types will still be 
there.

Original comment by brian.ta...@gmail.com on 8 Sep 2008 at 4:50