cosmology-tech / cosmology

CLI and TS library for the Cosmos ⚛️
MIT License
50 stars 20 forks source link

Method getPools returns wrong LcdPool[] properties #26

Open WaDadidou opened 1 year ago

WaDadidou commented 1 year ago

Hi, I got LcdPool[] by doing :

The issue is that the received LcdPool[] have properties like pool_assets and not poolAssets. Same for total_weight and pool_params. So, I have to "clean" my LcdPool[] before using it. With, for example if (pool.pool_params) pool.poolParams = pool.pool_params

Here is LcdPool : https://github.com/cosmology-tech/cosmology/blob/main/packages/core/src/types.ts#L284 Here is PoolsResponse : https://github.com/cosmology-tech/cosmology/blob/main/packages/core/src/clients/osmosis.ts#L21 Here is the method getPools() of OsmosisApiClient : https://github.com/cosmology-tech/cosmology/blob/main/packages/core/src/clients/osmosis.ts#L33

Wdyt ? Thank you for your repo and your time.