search

cosmology-tech / cosmos-kit

Universal wallet connector for the Cosmos ⚛️
https://cosmology.zone/products/cosmos-kit
BSD 3-Clause Clear License
183 stars 129 forks source link

Last connected wallet spams to connect in new session #393

Open codingki opened 7 months ago

codingki commented 7 months ago

When opening a new session, the last wallet connected send spams to connect

Repro steps:

  1. connect your dapp with leap wallet
  2. close session/tabs
  3. lock your wallet
  4. open your dapp again
liujun93 commented 7 months ago

It seems this is not a general issue for all wallets. I tried Keplr and it only popup once. I'll ask Leap team about it.

phips28 commented 7 months ago

I have also seen this.

How can we disable auto-connect?

barun1313 commented 7 months ago

Hey folks, thanks for bringing this up! We are looking into this right now

phips28 commented 7 months ago

would be great to have a config flag (reconnect: true) to disable the auto reconnect.

I think this line makes the problem (for us): https://github.com/cosmology-tech/cosmos-kit/blob/main/packages/core/src/manager.ts#L394

Asking the user to reconnect, also on page re-load when he declined on the last connect request. thats annoying UX.

baryon2 commented 6 months ago

@liujun93 @codingki This issue has been fixed in the latest version (0.10.5) of leap extension.

phips28 commented 6 months ago

Ok, I still saw this with Keplr. So maybe we are talking about 2 different topics 😄