cosmology-tech / cosmos-kit

Universal wallet connector for the Cosmos ⚛️
https://cosmology.zone/products/cosmos-kit
BSD 3-Clause Clear License
173 stars 129 forks source link

Add Crypto.com Wallet Extension #467

Closed lucaslee-crypto closed 1 month ago

lucaslee-crypto commented 1 month ago

Add Crypto.com Wallet Extension to cosmos-kit

pyramation commented 1 month ago

tested and installed the wallet, but while it showed up in the list, it didn't show up as installed. Looking into the code to get the extension

  const cdcwallet = (window as CdcwalletWindow).cdc_wallet?.cosmos;

  if (cdcwallet) {
    return cdcwallet;
  }

  if (document.readyState === 'complete') {
    if (cdcwallet) {
      return cdcwallet;
    } else {
      throw ClientNotExistError;
    }
  }

I went into my chrome console and can verify, I do not have window.cdc_wallet

Screen Shot 2024-06-04 at 11 13 57 AM

Here is the extension I installed — which I followed from the link

Screen Shot 2024-06-04 at 11 14 49 AM
lucaslee-crypto commented 1 month ago

tested and installed the wallet, but while it showed up in the list, it didn't show up as installed. Looking into the code to get the extension

Osmosis support is not in the current production build yet. We are planning to release the new version with it next week, which should by then contains the window property of cdc_wallet. (Below is a screenshot from our dev build) image

Is it possible to merge this PR before our new version is publicly released? Or would you have to verify this with a working production build on chrome store before this could be merged? If it is of the latter case then please wait for our update next week and I should mark this PR as draft for now.

pyramation commented 1 month ago

I understand it's working and in dev, makes sense it showed up as not installed. I published it so you can test:

 - @cosmos-kit/cdcwallet-extension@2.12.0
 - @cosmos-kit/cdcwallet@2.12.0